Code Review
With passion for the simplest
code
Auth
or
Company: blah Name: blah blah Experience: blah blah
blah
What is code review?
When do you need to use code review on your project?
Points that might be the reason: Too much boilerplate code (any changes are very risky)
External API need to be changed (just little bit)
Too much too complex business logic\rules
Code smells (again? After it was just refactored)
High load – only one simple line could f**k up all system
In each development iteration the number of bugs is more then in previous one
when the duck grunted
Bonus points
Each developer want to refactor everything on his own way
When you fix one bug and you introduce N bugs (where N >= 2)
Only you can change\fix your own code
Too much shitty code
How to code review
Types
Over-the-shoulder
Email pass-around
Pair programming
Tool-assisted code review
Timeline
TDD/unit test for critical functionality
Automatic code analysis – common conventions
Fish eye – tool similar to github functionality
UI tests (for regression)
Performance tests (not to f**k up on mass event)
Over-the-shoulder code review + elements of pair programming – this is really works
Quest
ions
Do you have any Qs?