This document is posted to help you gain knowledge. Please leave a comment to let me know what you think about it! Share it to your friends and learn new things together.
• Inspection session <= 2 hoursInspection session <= 2 hours• 1 - 2 sessions per day1 - 2 sessions per day
J. Nawrocki, PSP, Lecture 13
Fagan inspectionsFagan inspections
CD: CB definitionCD: CB definition
CU: CB usageCU: CB usage
IC: Interconnect callsIC: Interconnect calls
LO: LogicLO: Logic
MD: More detailMD: More detail
MN: MaintainabilityMN: Maintainability
OT: OtherOT: Other
PE: PerformancePE: Performance
PR: PrologPR: Prolog ... ...
Design error typesDesign error types
Question:Question:
What should beWhat should be
the design error typesthe design error types
for UML?for UML?
J. Nawrocki, PSP, Lecture 13
Fagan inspectionsFagan inspections
CC: Code commentsCC: Code comments
CU: CB usageCU: CB usage
DE: Design errorDE: Design error
IC: Interconnect callsIC: Interconnect calls
LO: LogicLO: Logic
MN: MaintainabilityMN: Maintainability
OT: OtherOT: Other
PE: PerformancePE: Performance
PR: PrologPR: Prolog ... ...
Code error typesCode error types
Question:Question:
What should beWhat should be
the design error typesthe design error types
for Java or HTML?for Java or HTML?
J. Nawrocki, PSP, Lecture 13
Fagan inspectionsFagan inspections
Are all constants defined?Are all constants defined?
If a queue is being manipulated , can the If a queue is being manipulated , can the execution be interrupted; If so, is queue execution be interrupted; If so, is queue protected by a locking structure?protected by a locking structure?
Are registers being restored on exits?Are registers being restored on exits?
Are all increment counts properly initialised (0 or Are all increment counts properly initialised (0 or 1)?1)?
Are absolutes shown where there should be Are absolutes shown where there should be symbolics?symbolics?
Are all blocks shown in design necessary?Are all blocks shown in design necessary?
Checklist for design inspectionChecklist for design inspection
Ex
Ex
Wr
Wr
Mis
sing
Mis
sing
J. Nawrocki, PSP, Lecture 13
Fagan inspectionsFagan inspections
Is correct condition tested?Is correct condition tested?
Is correct variable used or test?Is correct variable used or test?
Is each branch target correct?Is each branch target correct?
Is the most frequently exercised test leg the Is the most frequently exercised test leg the THEN clause?THEN clause?
Are all required parameters passed set Are all required parameters passed set correctly?correctly?
Does the inline expansion contain all required Does the inline expansion contain all required code?code?
Checklist for code inspection Checklist for code inspection T
est b
ranc
hT
est b
ranc
hIn
terc
onne
ctIn
terc
onne
ct
J. Nawrocki, PSP, Lecture 13
Fagan inspectionsFagan inspections
PR/M/Min L3: the prologue in the REMARKSPR/M/Min L3: the prologue in the REMARKS
section needs expansion.section needs expansion.
LO/W/Maj L172: NAME-CHECK is performed oneLO/W/Maj L172: NAME-CHECK is performed one
time too few.time too few.
DE/W/Min L175: the design should allow for the DE/W/Min L175: the design should allow for the
occurrence of a period in a lastoccurrence of a period in a last
name.name.
Error listError list
J. Nawrocki, PSP, Lecture 13
Fagan inspectionsFagan inspections
CC: Code commentsCC: Code comments
CU: CB usageCU: CB usage
DE: Design errorDE: Design error
IC: Interconnect callsIC: Interconnect calls
LO: LogicLO: Logic
MN: MaintainabilityMN: Maintainability
OT: OtherOT: Other
PE: PerformancePE: Performance
PR: PrologPR: Prolog
Major MinorMajor Minor
M W E M W E M W E M W E
Date ..............Date ..............Code inspection reportCode inspection report
• Questions posed by the author of the Questions posed by the author of the design - to encourage a thorough design - to encourage a thorough reviewreview
• Several brief reviews focusing on a part Several brief reviews focusing on a part of a work product (part of a design of a work product (part of a design document)document)
J. Nawrocki, PSP, Lecture 13
Phased inspectionsPhased inspections
1 Compliance with required internal documentation 1 Compliance with required internal documentation format. Also spelling and grammar can be format. Also spelling and grammar can be checked here.checked here.
2. Source code layout.2. Source code layout.
3. Readability.3. Readability.
4. Good programming practice (gotos, global 4. Good programming practice (gotos, global variables, ..).variables, ..).
5. Correct use of various programming constructs 5. Correct use of various programming constructs (updating control variables for while, closing (updating control variables for while, closing files, ...).files, ...).