Eclipsecon2010

Finding a new Home for ReviewClipse

Mario Bernhart, Kilian MattVienna University of Technology, Vienna/Austriawww.inso.tuwien.ac.at

Introduction

ReviewClipse (RC) is a poplular free code review plugin for Eclipse, which was created in 2009 at Vienna University of Technology

Presented at ECon09 and ESE09 and downloaded 10.000+ times since ECon09

RC is now open-sourced under the EPL and evolve into the Mylyn Reviews project

Actual RC will be further maintained, but we do not plan for enhancements

Project Scope

Mylyn Reviews aims to provide a task-based code review plugin for Mylyn

Main Features: Do code reviews based on Mylyn tasks Incorporate the review tasks in the Mylyn

task list Provide inline-commenting for source code

reviews Re-use the ReviewClipse SCM connectors

Strategy

Keep Mylyn Reviews simple and straight-forward for out-of-the-box usage E.g. keep the RC idea of not needing a

separate review serverAct as a base implementation for other

review solutions E.g. the Gerrit Connector (GSoC 2010)

Team up with the Mylyn SCM project to build one unified SCM connector type

Participants

Initial Committers: Mario Bernhart

(INSO) Kilian Matt (INSO) Christoph

Mayerhofer (INSO) Stefan Strobl (INSO)

Mentors: Mik Kersten Chris Aniszczyk

Interested parties: TaskTop ReviewClipse project Polarion Software

(Subversive Team) Vienna University of

Technology, INSO Group

Special thanks to Steffen Pingel

About ReviewClipse

Eclipse integrated easy to use UI Automatically triggered changeset-based

reviews Assignments of reviewers/authors with

filters No additional infrastructure: XML/SVN

based storage of review data Works with Subversive and Subclipse (EGit

and CVS implemented but not released) Create Mylyn tasks out of (bad) reviews

ReviewClipse Screenshot

ReviewClipse Architecture

Transition (Paradigm)

Change in the review paradigm: ReviewClipse is change-based Mylyn Reviews is task-based

Why task-based? the task is the core element of work a task state may serve as trigger for reviews a task relates to corresponding items (e.g.

list of changesets, the context or an attached patch) which may be scope of one review

Transition (Storage)

General aim still is to manage reviews without the need for a separate review server

Change in the storage type: ReviewClipse stores the review data to the

SCM Mylyn Reviews stores the review data to the

task management system We are currently investigating the option

of storing the data to the SCM or a CDO repository for Mylyn Reviews

11

Architecture of Mylyn Reviews

Major TODOs

Task-change-based reviews (review SCM changes that relate to one task)

Task-context-based reviews Inline commenting (like in the Crucible

Conn.) Integration of the ReviewClipse SCM

Connectors Conform and efficient UI If you want to participate mailto:

[email protected]

Current State

Proposal was accepted 02-2010 http://www.eclipse.org/proposals/mylyn-r

eviews/ Now in Incubation

http://eclipse.org/reviews/Prototype of patch-based reviews for

ECon2010 DEMO